Overview

Thanks for looking at this again.

I'm still wondering if this is the "best" approach in that Trio / iAPS has one method and LoopFollow a second and this is yet a third method. (What you've done may be decided to be the best method.).

I think an alternative that adds the suffix as an optional item in the code itself (similar to LoopFollow_Second, etc.) would be preferred because you could have 2 branches in the same fork supporting different bundle IDs.

The simplicity of the branch idea is then only a single fork is required to get 2 bundle IDs. I think your current method requires a separate fork (with fork environment variable) to get the different bundle ids.

As someone who actually builds two apps, I'm interested in your feedback on implementation. My thoughts above are theoretical.

This topic is on my list of things to review. And I appreciate you working with me on this.

Change Request

If we do decide to do this, I would want the user to be able to run without modifying their normal configuration. As part of that, I would only want a message reporting if the variable is present - not if it is not present.

In other works - the annotation indicated in the validate link below would not be there.

Test

The test failed so I stopped testing until this is modified to work.

Configuration

1. In my local clone of dev, I created a new branch dev_plus_pr416 and then executed git pull origin pull/416/head.
2. I then pushed dev_plus_pr416 to my docs-test github organization.
3. I confirmed the commit changes match the changes in the PR.
4. I modified the default branch to be dev_plus_pr416

Test Details

Test that all the yml files work without need for modification by the user.

• ✅ Validate Secrets: https://github.com/docs-test/LoopWorkspace/actions/runs/22546872859
• ❌ Add Identifiers
  • This failed and I repeated it: first failed link: https://github.com/docs-test/LoopWorkspace/actions/runs/22547082126
  • I restored to dev as the default branch and Add Identifiers succeeded: https://github.com/docs-test/LoopWorkspace/actions/runs/22547186227

Halted the test at this point. All the yml files need to work without modification required by the user.

To give some background, I will be building 2 instances of Loop. One for myself (usually DEV) and one for an extended family member (always Main).

@marionbarker My preference for having 2 independent forks vs 2 branches in the same fork is that it seems safer for 2 distinct Loop instances. I want to be able to work on/debug my fork, including repository-level changes, without risking any unforeseen effects on the 2nd Loop build.

From my understanding:

• Trio reads the TeamID/BundleID from the Config.xcconfig file. There might be an advantage for xcode builders, but I don't see the upside for GH builds. I'd be curious to discuss this with Trio users/devs.
• LoopFollow, in it's current form, uses hardcoded _Second/_Third forks to allow multiple builds. This is similar to what this PR proposes, but using repository-level variables. I will revisit my LoopFollow PR to improve it with what I've learned with Loop.

@marionbarker Can you try your tests again? I fixed a bug tonight.

Status

I would like to get this reviewed by some browser build "experts".

I can see where this might be helpful when a breaking change is happening in addition to the use case mentioned by the author. People may want to review the new version of the app without overwriting their build on their looping phone.

Seems like we should add an option to personalize the display name too. Then a user could switch between Mac-Xcode and Browser Build for the same app ID.

Mac-Xcode build test

There is a standard process to configure a different bundle ID with Xcode. I used that in a manner to mock up the way this PR is configured, in other words, I used "-{suffix}" after TeamID. I used a different suffix for the Mac test than the Browser Build test so I could tell the identifiers from the two methods apart.

I added "-TP" to the bundle id and name with Mac and "-TTP" using the Browser Build method. See details for the Mac change at the end of this comment.

The new Identifiers that show up all start with XC as expected, with the identifiers listed below. The first one would be used to make a new app in the app store if I were going to use browser build. I was a little puzzled why the other certificates that we create with browser build do not show up. Answer is the identifiers have to be created with browser build so provisioning profiles can be added, whereas in Xcode build, the provisioning profile is updated as part of the build process on the local machine.

These are the 3 new identifiers that are created on my developer site from the Xcode build.

com.7PT47XGDN4-TP.loopkit.Loop
com.7PT47XGDN4-TP.loopkit.Loop.Loop-Intent-Extension
com.7PT47XGDN4-TP.loopkit.Loop.LoopWidgetExtension

Test this PR

I did a fresh fork with a new repo name, pushed this branch to the new fork. configured the new branch as the default and set the environment variable TEAMID_SUFFIX = TTP.

I tested some Actions with the new fork

• Action: Validate Secrets - success
• Action: Add Identifiers

There are 6 new Identifiers from the Add Identifiers Action:

com.7PT47XGDN4-TTP.loopkit.Loop
com.7PT47XGDN4-TTP.loopkit.Loop.Loop-Intent-Extension
com.7PT47XGDN4-TTP.loopkit.Loop.LoopWidgetExtension
com.7PT47XGDN4-TTP.loopkit.Loop.statuswidget
com.7PT47XGDN4-TTP.loopkit.Loop.LoopWatch
com.7PT47XGDN4-TTP.loopkit.Loop.LoopWatch.watchkitextension

I don't want to create another app that I will then hide, so I stopped here.

Details for Mac Xcode modification

I made the change in the LoopWorkspace folder for the one clone where I want a unique app built.

diff --git a/LoopConfigOverride.xcconfig b/LoopConfigOverride.xcconfig
index 2969db2..702e793 100644
--- a/LoopConfigOverride.xcconfig
+++ b/LoopConfigOverride.xcconfig
@@ -1,10 +1,10 @@
 #include? "../../LoopConfigOverride.xcconfig"
 
 // Override this if you don't want the default com.${DEVELOPMENT_TEAM}.loopkit that loop uses
-// MAIN_APP_BUNDLE_IDENTIFIER = com.myname.loop
+MAIN_APP_BUNDLE_IDENTIFIER = com.${DEVELOPMENT_TEAM}-TP.loopkit
 
 // Customize this to change the app name displayed
-//MAIN_APP_DISPLAY_NAME = Loop
+MAIN_APP_DISPLAY_NAME = Loop-TP
 
 // Customize this to change the URL to open Loop to something other than the display name
 //URL_SCHEME_NAME = $(MAIN_APP_DISPLAY_NAME)